[PATCH] Remove password level (now only lowercase the plaintext password, do not try combinations)

Andrew Bartlett abartlet at samba.org
Fri Jun 7 22:13:56 MDT 2013


On Mon, 2013-06-03 at 11:15 +1000, Andrew Bartlett wrote:
> On Mon, 2013-06-03 at 10:19 +1000, Andrew Bartlett wrote:
> > I was looking at adding the deprecated flag to 'password level' so that
> > we could remove it in the future, and realised it was already
> > deprecated!
> > 
> > So, given the discussion with Yannick, who has 'password level = 0' (ie,
> > the default) in his smb.conf, I think this is reasonable.  
> > 
> > That is, if your site relies on plaintext passwords from CIFS clients,
> > that the requirement be that the client pass the password in correctly,
> > or that you have the password in the system be in lower case. 
> > 
> > This does not impact encrypted passwords at all, and does not remove
> > support for any known client.  
> > 
> > Simo,
> > 
> > I think I've addressed your concerns in my other mail, I agree my
> > description was confusing. 
> > 
> > Please review/comment/possibly push. 
> 
> Attached are two more patches to remove the remaining references.

Can I please have these patches reviewed?

Thanks,

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-auth-Remove-password-level.patch
Type: text/x-patch
Size: 8937 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130608/059eb804/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-docs-Do-not-encourage-unix-passwords-and-remove-refe.patch
Type: text/x-patch
Size: 1608 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130608/059eb804/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Remove-remaining-references-to-password-level-in-the.patch
Type: text/x-patch
Size: 7585 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130608/059eb804/attachment-0002.bin>


More information about the samba-technical mailing list