[CTDB] Some patches

[Amitay Isaacs]

On Fri, Jun 7, 2013 at 5:35 PM, Sumit Bose <sbose at redhat.com> wrote:

> On Fri, Jun 07, 2013 at 11:32:28AM +1000, Amitay Isaacs wrote:
> > Hi Mathieu,
> >
> >
> > On Fri, Jun 7, 2013 at 6:54 AM, Mathieu Parent <math.parent at gmail.com
> >wrote:
> >
> > > (Please cc me as I'm not on the list)
> > > Hi,
> > >
> > > I attached some patches done during Debian packaging (against 2.2):
> > >
> > > 0005-Fix-tdb.h-path.patch: This allows building ctdb with system
> libtdb.
> > >
> > > 0004-Include-config.h-in-libctdb-ctdb.c-Closes-703551.patch: Fixes
> > > inconsistent use of _GNU_SOURCE (if you have questions, ask the
> > > original reporter of http://bugs.debian.org/703551).
> > >
> >
> > Thanks for the patches.
> >
> > 0002-Display-compiler-commands.patch: This one has already been
> > > reported, I still think that showing compiler commands is useful (you
> > > decide what you do ...).
> > >
> >
> > Instead of always enabling or disabling the compiler commands, how about
> > the attached patch? Does that work for you?
> >
> >
> > >
> > > Also, don't forget to update config.sub and config.guess from time to
> time.
> > >
> >
> > Will do.
> >
> >
> > > There are also patches on the Fedora side:
> > > http://pkgs.fedoraproject.org/cgit/ctdb.git/tree/, please take a look.
> > >
> >
> >  Thanks for pointing out fedora ctdb patches, I will check them out.
>
> Hi Amitay,
>
> I'm the maintainer of the Fedora ctdb package. I would be happy if you
> can consider some of the patches for upstream. All the patches were
> send to samba-technical but I guess that was before you took the
> maintainer-ship of ctdb.
>
> I think most interesting would be the inclusion of the patches which
> adds support for systemd. The were developed with help and feedback from
> David Disseldorp and Jeff Layton.
>
> Please tell me if you need more details to one of the patches or if I
> should resend them for review to samba-technical.
>
> bye,
> Sumit
>
>
Hi Sumit,

I have had a look at the patches. Most of the patches look straightforward.

This patch is already included
(0001-Fix-for-tevent-autoconf-check.patch<http://pkgs.fedoraproject.org/cgit/ctdb.git/tree/0001-Fix-for-tevent-autoconf-check.patch>
).

I will work through the other patches and push them upstream.


Martin, can you look at the patches for init script and systemd changes?

Amitay.