[CTDB] Some patches

[Mathieu Parent]

(still cc me)

2013/6/7 Amitay Isaacs <amitay at gmail.com>:
> Hi Mathieu,
>
>
> On Fri, Jun 7, 2013 at 6:54 AM, Mathieu Parent <math.parent at gmail.com>
> wrote:
>>
>> (Please cc me as I'm not on the list)
>> Hi,
>>
>> I attached some patches done during Debian packaging (against 2.2):
>>
>> 0005-Fix-tdb.h-path.patch: This allows building ctdb with system libtdb.
>>
>> 0004-Include-config.h-in-libctdb-ctdb.c-Closes-703551.patch: Fixes
>> inconsistent use of _GNU_SOURCE (if you have questions, ask the
>> original reporter of http://bugs.debian.org/703551).
>
>
> Thanks for the patches.
>
>> 0002-Display-compiler-commands.patch: This one has already been
>> reported, I still think that showing compiler commands is useful (you
>> decide what you do ...).
>
>
> Instead of always enabling or disabling the compiler commands, how about the
> attached patch? Does that work for you?

Great, I like it! I didn't know that "@" could be in a variable.

Maybe V can be renamed to the more explicit VERBOSE or MAKE_VERBOSE?

>>
>>
>> Also, don't forget to update config.sub and config.guess from time to
>> time.
>
>
> Will do.
>
>>
>> There are also patches on the Fedora side:
>> http://pkgs.fedoraproject.org/cgit/ctdb.git/tree/, please take a look.
>
>
>  Thanks for pointing out fedora ctdb patches, I will check them out.

Good. I'm particularly interrested in
0001-Extract-some-init-functions-into-a-separate-file.patch, as we
also have a custom init script in Debian.

Regards
--
Mathieu