[patch] make the logging header customisable
jra at samba.org
Thu Jun 6 10:21:22 MDT 2013
On Wed, Jun 05, 2013 at 11:23:03PM -0700, Matthieu Patou wrote:
> It's patch made on master, I just pull master and tried to reapply
> and it works
Cool ! That makes things easier :-).
> Well I wanted to avoid dynamic memory allocation and tried to be
> very cautious about the overflow (and I actually did some testing to
> check that no matter we truncate), we could use a static buffer as
> well where the stack is not easily accessible.
> Note that the previous version has also this 200 buffer in the stack.
Yes, I'm not suprised :-). Although maybe we should improve
> Thanks for the feedback, much appreciated that you came back to me !
No problem. I should have some free time to work with you
on this by the end of next week.
More information about the samba-technical