[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jun 6 04:39:39 MDT 2013

On Thu, Jun 06, 2013 at 04:31:02AM +0200, Andrew Bartlett wrote:
> - Log -----------------------------------------------------------------
> commit 7d8354c719fa620a580f6d7d322ca80185c50c7e
> Author: Christof Schmitt <christof.schmitt at us.ibm.com>
> Date:   Wed Jun 5 17:08:03 2013 -0700
>     smbd: Change logging when SET_OFFLINE is not supported
>     A client can send a request to set the OFFLINE attribute. In the default
>     code this is not supported and triggers a log message each time. Change
>     this to only log with level 0 when an actual errors occurs, and log
>     ENOTSUP with level 10.
>     Signed-off-by: Christof Schmitt <christof.schmitt at us.ibm.com>
>     Reviewed-by: Andrew Bartlett <abartlet at samba.org>

When looking at https://wiki.samba.org/index.php/CodeReview,
I see the lines

> Each commit in master should have been reviewed by at least
> two samba team members. For this purpose, involvement in
> patch creation is considered as reviewing.

I know there's a "should" in here, and we have addressed
this recently. I know you don't feel bound by this "should"
and you feel a big pain in following that "should", but can
I ask you kindly to also adhere to it, like many other
committers do?



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list