[PATCH] Finally run bind9_dlz spnego test, fix drs delete behaviour

[Andrew Bartlett]

On Tue, 2013-06-04 at 16:39 +1000, Andrew Bartlett wrote:
> On Mon, 2013-06-03 at 22:27 +1000, Andrew Bartlett wrote:
> > On Sun, 2013-06-02 at 23:05 +1000, Andrew Bartlett wrote:
> > > I've been frustrated for over 6 months by why adding some 'simple' tests
> > > to confirm that some of the crypto in the bind9_dlz code works because
> > > it suddenly broke make test, particularly dbcheck.
> > > 
> > > The attached patches just passed a private autobuild.  They add the
> > > 'problem' tests, but first we fix the behaviour of DRS-initiated object
> > > deletes.
> > > 
> > > Please review/push/comment (this patch series includes the usnChanged
> > > series I posted a few days ago). 
> > > 
> > > >From here, I would like to continue to improve the tests - the tests in
> > > source4/torture/drs/python/delete_object.py could be trivially extended
> > > to add a 'description' and 'memberOf' element that we should ensure gets
> > > deleted on both hosts, for example.  We could also watch usnChanged
> > > values to ensure we delete the right stuff, but for now I'm simply
> > > stunned that this could ever have worked with this incorrect!
> > 
> > Just as a heads-up I'm continuing to work on these patches.  The point
> > tests I added (rather than just waiting for the dbcheck) show the issue
> > isn't totally resolved, but is better.  (I somehow found a
> > member/memberOf link left over...).
> > 
> > Review of this much would be helpful, but expect additional changes as
> > we finally start to get this right.  
> 
> I've not finished the patch yet, but what seems clear is that the issue
> comes from processing (rather that dropping/ignoring, as we should)
> linked attributes and to deleted objects. 

I'm almost shocked to finally have this finished, given how long this
problem has dogged me.  The patches are in my fix-drs-testing-14 branch,
and attached.

Not only does this open up the chance to do more DRS testing, and more
unrelated fixes to DRS replication (now that adding tests does not
suddenly cause 'unrelated' breakages), it also allows us to resume
adding tests of the bind9 DLZ module, which stalled out when adding
bind9 tests broke stuff.

The patches handle both normal and linked attributes, following all the
special rules for deleted objects. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Fix-behaviour-for-when-to-update-the-USN-when-t.patch
Type: text/x-patch
Size: 2721 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dsdb-tests-ldap.py-Fix-quoting-of-print-statements.patch
Type: text/x-patch
Size: 4039 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dsdb-tests-ldap.py-Add-test-for-usn-behaviour-on-cer.patch
Type: text/x-patch
Size: 10587 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dsdb-Prune-deleted-objects-of-links-and-extra-attrib.patch
Type: text/x-patch
Size: 15981 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-dsdb-Improve-DRS-deleted-link-source-target-handing-.patch
Type: text/x-patch
Size: 7819 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-scripting-join.py-Handle-creating-the-dns-NAME-accou.patch
Type: text/x-patch
Size: 10686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-scripting-samba_upgradedns-Tighten-up-exception-and-.patch
Type: text/x-patch
Size: 3500 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-selftest-Test-creation-of-the-dns-SERVER-account-dur.patch
Type: text/x-patch
Size: 1169 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-selftest-Start-internal-DNS-server-on-domain-provisi.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-selftest-Add-a-basic-test-of-samba_upgradedns.patch
Type: text/x-patch
Size: 3579 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-torture-Ensure-that-GSSAPI-and-SPNEGO-packets-are-ac.patch
Type: text/x-patch
Size: 5779 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-dsdb-repl_meta_data-Use-dsdb_request_add_controls.patch
Type: text/x-patch
Size: 1898 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-lib-param-Remove-last-use-of-password-level.patch
Type: text/x-patch
Size: 899 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-dsdb-tests-Add-member-memberOf-checking-to-delete_ob.patch
Type: text/x-patch
Size: 16769 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-dsdb-Include-MS-ADTS-doc-references-on-deleted-objec.patch
Type: text/x-patch
Size: 1589 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130604/9fdd1347/attachment-0014.bin>