[PATCH] Finally run bind9_dlz spnego test, fix drs delete behaviour

[Andrew Bartlett]

On Mon, 2013-06-03 at 22:27 +1000, Andrew Bartlett wrote:
> On Sun, 2013-06-02 at 23:05 +1000, Andrew Bartlett wrote:
> > I've been frustrated for over 6 months by why adding some 'simple' tests
> > to confirm that some of the crypto in the bind9_dlz code works because
> > it suddenly broke make test, particularly dbcheck.
> > 
> > The attached patches just passed a private autobuild.  They add the
> > 'problem' tests, but first we fix the behaviour of DRS-initiated object
> > deletes.
> > 
> > Please review/push/comment (this patch series includes the usnChanged
> > series I posted a few days ago). 
> > 
> > >From here, I would like to continue to improve the tests - the tests in
> > source4/torture/drs/python/delete_object.py could be trivially extended
> > to add a 'description' and 'memberOf' element that we should ensure gets
> > deleted on both hosts, for example.  We could also watch usnChanged
> > values to ensure we delete the right stuff, but for now I'm simply
> > stunned that this could ever have worked with this incorrect!
> 
> Just as a heads-up I'm continuing to work on these patches.  The point
> tests I added (rather than just waiting for the dbcheck) show the issue
> isn't totally resolved, but is better.  (I somehow found a
> member/memberOf link left over...).
> 
> Review of this much would be helpful, but expect additional changes as
> we finally start to get this right.  

I've not finished the patch yet, but what seems clear is that the issue
comes from processing (rather that dropping/ignoring, as we should)
linked attributes and to deleted objects. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org