[PATCH 2/2] cifs: Expand max share name length to 256

Jeff Layton jlayton at redhat.com
Thu Jul 25 11:45:32 MDT 2013


On Thu, 25 Jul 2013 13:35:21 -0400
scott.lovenberg at gmail.com wrote:

> From: Scott Lovenberg <scott.lovenberg at gmail.com>
> 
> The old max share name length limit was 80 due to Windows NET SHARE
> command not allowing more than that.  However, share names can be much
> longer.  This is a more reasonable maximum share name length.
> 
> Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com>
> ---
>  include/uapi/linux/cifs/cifs_mount.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/cifs/cifs_mount.h b/include/uapi/linux/cifs/cifs_mount.h
> index 1485781..f7e4aee 100644
> --- a/include/uapi/linux/cifs/cifs_mount.h
> +++ b/include/uapi/linux/cifs/cifs_mount.h
> @@ -20,6 +20,6 @@
>  #define CIFS_MAX_DOMAINNAME_LEN 256 /* max fully qualified domain name */
>  #define CIFS_MAX_USERNAME_LEN   256 /* reasonable max for current servers */
>  #define CIFS_MAX_PASSWORD_LEN   512 /* Windows max seems to be 256 wide chars */
> -#define CIFS_MAX_SHARE_LEN 80
> +#define CIFS_MAX_SHARE_LEN      256 /* reasonable max share name length */
>  
>  #endif /* _CIFS_MOUNT_H */

Looks good...

Reviewed-by: Jeff Layton <jlayton at redhat.com>


More information about the samba-technical mailing list