[PATCH] RFC cifs-utils: Use autoconf to get kernel headers

[Scott Lovenberg]

On Mon, Jul 22, 2013 at 8:21 PM, Chen Gang <gang.chen at asianux.com> wrote:

> On 07/23/2013 02:27 AM, Jeff Layton wrote:
> > On Mon, 22 Jul 2013 13:47:23 -0400
> > scott.lovenberg at gmail.com wrote:
> >
> >> From: Scott Lovenberg <scott.lovenberg at gmail.com>
> >>
> >> This is an RFC for how we'd use autoconf to get the Linux kernel headers
> >> in include/uapi/linux/cifs.h.  If this is the correct approach, I'll
> >> formalize this patch.  I've never played with autoconf before so this is
> >> completely untested but should (read: might) probably work.
> >>
> >> Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com>
> >> ---
> >>  configure.ac |  3 +++
> >>  mount.cifs.c | 27 +++++++++++++++++++--------
> >>  2 files changed, 22 insertions(+), 8 deletions(-)
> >>
> >
> > I think the first step is to do a kernel patch that makes this cifs.h
> > file. I won't commit any sort of patch like this until that's committed
> > first.
> >
> > Also "cifs.h" is somewhat generic. I think you should probably name it
> > a bit more specifically -- maybe include/uapi/linux/cifs/cifs_mount.h...
> >
>
> Do we need add prefix 'CIFS_' for the macro constants to let them in
> their own name space ? (e.g. use 'CIFS_MAX_DOMAIN_SIZE' instead of
> 'MAX_DOMAIN_SIZE').
>
> Thanks.
>
>
>
--
> Chen Gang
>

That's probably a good idea.  I'll be submitting this patch set later today.

-- 
Peace and Blessings,
-Scott.