[PATCH] Fix bug 10025 - Lack of Sanity Checking in calls to malloc()/calloc().

Elia Pinto gitter.spiros at gmail.com
Thu Jul 25 07:07:58 MDT 2013


2013/7/18 Jeremy Allison <jra at samba.org>:
> On Wed, Jul 17, 2013 at 05:42:03PM -0400, Simo wrote:
>> On Wed, 2013-07-17 at 11:11 -0700, Jeremy Allison wrote:
>> > Written by Bill Parker <wp02855 at gmail.com>. Can I get
>> > another Team reviewer please ?
>> >
>> > Thanks,
>>
>> I think ccan, iniparser, popt and heimdal related patches should be sent
>> upstream first and later synced back by us. We should not 'fork' for
>> this stuff.
>>
>> So nack for those, and ack for the rest.
Hi to all. Sorry for the late response.

I am Elia Pinto, a popt/rpm5 comantainer. From many years popt use
xcalloc that already catch these issue. FWIW, very recently popt (and
rpm5) was analyzed by coverity thanks to Jeff Johnson (in CC) (Jun 24,
2013)  - 0.00 Defect Density for popt. What is more the internal test
suite permit popt to cover  98% of its code, last time i checked,
thanks to the API sanity checker
http://ispras.linuxbase.org/index.php/API_Sanity_Checker.

Best Regards


More information about the samba-technical mailing list