[PATCH] s4-lib/socket: Allocate a the larger sockaddr_un and not just a sockaddr_in in unixdom_get_peer_addr()
abartlet at samba.org
Wed Jul 24 03:57:34 MDT 2013
On Wed, 2013-07-24 at 10:55 +0200, Stefan (metze) Metzmacher wrote:
> Am 24.07.2013 08:47, schrieb Andreas Schneider:
> > On Wednesday 24 July 2013 10:31:19 Andrew Bartlett wrote:
> >> On Mon, 2013-07-22 at 21:22 -0700, Richard Sharpe wrote:
> >>> Hmmm,
> >>> Does anyone know what caused this? The failure seems to be in the
> >>> source4 code but my change was in source3.
> >> This did need to be looked into.
> >> The attached patch should fix it. Please review/push.
> > Great catch! Can you please open a bug and backport it?
> Thanks Andrew, I was looking at that for a few weeks now
> and couldn't find the reason...
Yeah, this has been a stubborn one. For me the clue was realising that
it was an RPC request, and so over unix domain sockets.
> And here's an additional fix that's needed.
Thanks, I've reviewed and pushed that. I'll cherry-pick and attach both
to the bug once this autobuild is done.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical