[Patch] winbind_lookup_names() fails because of NT_STATUS_CANT_ACCESS_DOMAIN_INFO

[Florian Riehm]

Hi,

please have a look to the attached patch.
It fixes a probable regression introduced by
commit c64473ab88ca36462e7976bf0006bc092386894c
(Bug 9439 - ncacn_ip_tcp reconnection code for lsa lookups still broken)
in samba-3.6.10.

Before samba 3.6.10 after a failed cm_connect_lsa_tcp(),
domain->can_do_ncacn_ip_tcp was set to false and cm_connect_lsat()
was called to try lookup again. Now after a failed cm_connect_lsat it just
returns without changing domain->can_do_ncacn_ip_tcp.

A few weeks ago I have reported the problem as bug 9899 but I haven't seen
any reaction yet. I would be glad if somebody here could have a look to my
patch.

Thanks in advance!

Regards,

Florian.



diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c
index b14a4f8..318d2e0 100644
--- a/source3/winbindd/winbindd_msrpc.c
+++ b/source3/winbindd/winbindd_msrpc.c
@@ -1163,6 +1163,7 @@ static NTSTATUS winbindd_lookup_names(TALLOC_CTX *mem_ctx,
  connect:
 	status = cm_connect_lsat(domain, mem_ctx, &cli, &lsa_policy);
 	if (!NT_STATUS_IS_OK(status)) {
+		domain->can_do_ncacn_ip_tcp = false;
 		return status;
 	}