[PATCH] cifs: extend the buffer length enought for sprintf() using
scott.lovenberg at gmail.com
Thu Jul 18 00:47:08 MDT 2013
On Wed, Jul 17, 2013 at 9:08 PM, Chen Gang <gang.chen at asianux.com> wrote:
> On 07/18/2013 02:27 AM, Scott Lovenberg wrote:
>> On Tue, Jul 16, 2013 at 10:06 PM, Steve French <smfrench at gmail.com> wrote:
>>>> If this is correct for the domain size, MAX_DOMAIN_SIZE in the
>>>> cifs-utils mount helper (mount.cifs.c) has to be changed. It is
>>>> currently 64 + null terminator. I can open a bug and patch it if this
>>>> is correct.
>>>> CC'ing Jeff Layton since he maintains the cifs-utils package.
>>>> Peace and Blessings,
>>> http://support.microsoft.com/kb/909264 indicates that (at least for
>>> Microsoft) domain names can be considerably longer than 64 bytes, so
>>> this patch seems reasonable. Merged into cifs-2.6.git - if anyone
>>> objects or wants to add ack/reviewed let me know.
>>> "The maximum length of ... the fully qualified domain name (FQDN) is
>>> 63 octets per label and 255 bytes per FQDN. This maximum includes 254
>>> bytes for the FQDN and one byte for the ending dot."
>> Thanks, Steve. I'll patch this tonight.
> Firstly, thank you for your work.
> Hmm... could you please wait for 1-2 days so can let this patch given
> more checking by another contributors ?
> If possible, after finish discussing, I should/will send patch v2 for it.
> Is it OK ?
> Chen Gang
Thank you for your work. :)
That's completely reasonable. I'll submit in a day or two.
Peace and Blessings,
More information about the samba-technical