I think there is a memory leak here ...

[Jeremy Allison]

On Wed, Jul 17, 2013 at 08:54:58AM +0200, Volker Lendecke wrote:
> On Tue, Jul 16, 2013 at 05:41:54PM -0700, Richard Sharpe wrote:
> > Hi folks,
> > 
> > I think the following is needed:
> > 
> > diff --git a/source3/smbd/notify_inotify.c b/source3/smbd/notify_inotify.c
> > index 4e9a87e..efb659f 100644
> > --- a/source3/smbd/notify_inotify.c
> > +++ b/source3/smbd/notify_inotify.c
> > @@ -398,6 +398,7 @@ NTSTATUS inotify_watch(struct sys_notify_context *ctx,
> >         if (w->path == NULL) {
> >                 inotify_rm_watch(in->fd, wd);
> >                 *filter = orig_filter;
> > +               TALLOC_FREE(w);
> >                 return NT_STATUS_NO_MEMORY;
> >         }
> 
> Yep, correct. Consider this reviewed-by me.

Pushed to autobuild.