BUG Commit Message

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jul 12 06:16:29 MDT 2013


On Fri, Jul 12, 2013 at 01:22:51PM +0200, Stefan (metze) Metzmacher wrote:
> Am 12.07.2013 13:22, schrieb David Disseldorp:
> > Hi Andreas,
> > 
> > Thanks for bringing up the topic...
> > 
> > On Fri, 12 Jul 2013 12:31:36 +0200
> > Andreas Schneider <asn at samba.org> wrote:
> > 
> >> Hello,
> >>
> >> could we try to use the same scheme in the commit message for fixing bugs?
> >>
> >> 	BUG XXXX: Short comment
> >>
> >> e.g.
> >>
> >> 	BUG 8997: Change libreplace GPL source to LGPL.
> >>
> >> 	BUG 9817: Fix 'map untrusted to domain' with NTLMv2.
> >>
> >> It would just make it easier to find patches for bugs in the git log and is 
> >> easily parse-able.
> >>
> >> Same for Coverity:
> >>
> >> 	CID XXXXXX: Fix resource leak in open_sockets().
> > 
> > I'm all for using a consistent bugzilla tag in bug fix commit messages,
> > but would prefer that the tag sits alongside (above) other Signed-off-by
> > / Reviewed-by attributes, e.g:
> > bugzilla.samba.org: XXXX
> 
> I like that...

What if someone decides after a patch went into master that
we want this in a release branch? Do we push -f an updated
master then?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list