[PATCH] classicupgrade: tell tdb not to use fsync

Björn Jacke bj at sernet.de
Thu Jul 11 05:06:37 MDT 2013

On 2013-07-11 at 08:47 +1000 Andrew Bartlett sent off:
> On Wed, 2013-07-10 at 18:37 +0200, Björn Jacke wrote:
> > this speeds up the classicupgrade process a lot and we don't really need
> > syncing for data security here.
> > 
> > Signed-off-by:: Björn Jacke <bj at sernet.de>
> I'm curious as to if this was seen before or after I added
> 34820602715cc8936179091e188993f7a42808ac to the tree.  (Wrapping it in
> one transaction should also help avoid the fsync(), but my patch may not
> have actually done that).

actually I didn't notice that change but I tested once more with master now: a
mid-size domain classicupgrade with master takes here 50sec while it takes only
10sec with my change turning off tdb syncing.

> Either way, I agree with the idea and think we should probably do the
> same during provision and join as well. 

but the actuall join and provision don't do as much hammering on the TDB files
as the classicupgrade, I think. So the benefit here would be not very big, or?

> I don't however think the patch is in the right spot - it should be in
> the run() routine.  (I was going to suggest it being in
> upgrade_from_samba3, but that is essentially a library routine and
> changing the global environment there would be rude). 

feel free to move it to some other place if you think another place is nicer

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
  ☎ +49-551-370000-0, ℻ +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130711/a9f6a6ea/attachment.pgp>

More information about the samba-technical mailing list