[PATCH] waf: Build with RELRO if supported by the compiler.

Christian Ambach ambi at samba.org
Thu Jul 4 14:51:47 MDT 2013


Am 04.07.13 18:29, schrieb Andreas Schneider:
> Make sure we create binaries with full RELocation Read-Only support. See
> https://isisblogs.poly.edu/2011/06/01/relro-relocation-read-only/
> for more details.
>
> The default is to check if the compiler supports RELRO and then enable
> it. Specifying '--with-relro' will make it mandatory and
> '--without-relro' will disable it.
>
> Signed-off-by: Andreas Schneider <asn at samba.org>

> +    opt.add_option('--with-relro',
> +                  help=("Build with full RELocation Read-Only (RELRO)" +
> +                        "(default if supported by compiler)"),
> +                  action="store_true", dest='enable_relro')
> +    opt.add_option('--without-pie',
> +                  help=("Disable RELRO builds"),
> +                  action="store_false", dest='enable_relro')
> +

Shouldn't this be --without-relro? Looks like a copy&paste error.

Cheers,
Christian


More information about the samba-technical mailing list