[PATCH] selftest: Print error message when smbd does not have ADS support

Christof Schmitt christof.schmitt at us.ibm.com
Wed Jul 3 14:08:46 MDT 2013


On Wed, Jul 03, 2013 at 01:06:32PM -0700, Christof Schmitt wrote:
> When smbd cannot be compiled with ADS support, setting up the s3member
> environment fails with:
> 
> Can't use string ("UNKNOWN") as a HASH ref while "strict refs" in use at
> /home/cschmit/test/samba/selftest/selftest.pl line 852.
> 
> Add an explicit error message for the missing ADS support to make this
> easier to debug.
> ---
>  selftest/target/Samba3.pm |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
> index 26f5e92..20587bf 100755
> --- a/selftest/target/Samba3.pm
> +++ b/selftest/target/Samba3.pm
> @@ -25,6 +25,7 @@ sub have_ads($) {
>  	close IN;
> 
>  	# If we were not built with ADS support, pretend we were never even available
> +	print "smbd does not have ADS support\n" unless $found_ads;
>  	return $found_ads;
>  }
> 
> -- 
> 1.7.1
> 

I forgot to include the Signed-off-by, please see the
resubmitted patch.

Sorry for the noise...

-- 
Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)



More information about the samba-technical mailing list