[PATCH] Fix tevent standard to fallback to poll instead of select.

Jeremy Allison jra at samba.org
Thu Jan 31 00:29:59 MST 2013


On Wed, Jan 30, 2013 at 11:42:20AM -0800, Jeremy Allison wrote:
> Since Volker's patchset 4f9cffbae6a60268140eba5e457ac7e86cac6246..15596a8d9c5a578fa98e110350d15265c90e8f03
> in master winbindd now uses the tevent "standard" backend instead of explicitly
> using the poll backend.
> 
> This massively improves scalability on Linux, but causes an issue
> on non-Linux platforms. This is because the current tevent "standard"
> backend is a mixture of cut-and-paste of the epoll backend mixed with
> a runtime fallback to select() for plafroms that don't have epoll.
> 
> Attached is a patchset I've tested thoroughly (on Linux at least :-)
> that removes the cut-and-pasted epoll/select based code and replaces
> it with a new clean "standard" backend that wraps the existing epoll
> and poll tevent backend modules, and safely falls back from epoll
> to poll if epoll doesn't exist on the compiling platform, or if
> epoll exists but has a runtime error.
> 
> Ira, I'd be very interested to hear reports of testing on
> Solaris, and Richard, similarly for testing on FreeBSD.
> 
> Please review and push to master if you're happy with it !

I'm withdrawing this patch. It turns out there are
some serious issues with the tevent_poll() backend
that are nothing to do with this change that need
fixing before we can safely fall-back from epoll
to poll.

I'm off to FOSDOM tomorrow for a week but I'll try
and keep working on these issues whilst on the road.

Cheers,

	Jeremy.


More information about the samba-technical mailing list