Patch

[simo]

On Wed, 2013-01-30 at 12:58 +0100, Volker Lendecke wrote:
> Hi!
> 
> If someone feels like it, please review and push the
> attached patch.
> 
> Thanks,
> 
> Volker Lendecke
> 

Volker I am all for code reviews but I have to ask to please make better
submissions.

I see this mail and the subject is 'Patch', that tells me nothing, so I
am, ok, let's see what this is about and reach the body of the message,
which tells me: absolutely nothing.

Please use a subject like "[PATCH] Fixes about foo"
and in the body an explanation about why you made it.

In this case you could even avoid the body, and just have:
Subj: [PATCH] Fix typo in code comment
Body: See subject.

But at least I have a way to see immediately if this is an important
patch or something I can check later.

For non-typos a good subject would tell me if this is in an area I know
about and can/should review myself, or is something I should better let
others comment on.

Sorry to pick on you, this is not meant to be a personal comment, I just
took the bait to make a general complaint about patches sent w/o
explanation in subject/body.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>