[PATCH] Fix ldb lockout after DRS failures

Matthieu Patou mat at samba.org
Fri Jan 25 22:40:28 MST 2013


On 01/25/2013 04:44 PM, Andrew Bartlett wrote:
> This patch, required for my server_id patches (apparently) just passed
> an autoubuild.  It is designed to address this message Matthieu got when
> trying to autobuild my second server_id patch.
>
> In short, as we fix the issues that were really breaking DRS, we are
> finding issues with running DRS.  It is a can of worms, but we are
> making progress, and if we can get these into 4.0.2, then we really will
> have a much more reliable replication system.
>
> The issue was that if a single DRS replication failed at the pre-commit
> stage, that we would get into a limbo-land were one half of ldb thought
> there was still an active transaction, while another half thought there
> wasn't.  That ldb handle then became read-only until closed.
>
> Andrew Bartlett
I'm still surprised that fixing timeout in the IRPC is the root cause of 
this problem but maybe by removing the timeout we were unmasking problems.

Still I review the patch positively.

Matthieu.

-- 
Matthieu Patou
Samba Team
http://samba.org



More information about the samba-technical mailing list