[PATCH] Re: irpc/tevent losing replies

[Matthieu Patou]

On 01/25/2013 04:46 PM, Andrew Bartlett wrote:
> On Thu, 2013-01-24 at 23:16 -0800, Matthieu Patou wrote:
>> On 01/24/2013 06:22 PM, Andrew Bartlett wrote:
>>> On Wed, 2013-01-23 at 23:17 -0800, Matthieu Patou wrote:
>>>> Hello
>>>>
>>>> While working on DRS issues with andrew's branch I started to notice
>>>> message like "IRPC callback failed for DsReplicaSync - NT_STATUS_IO_TIMEOUT"
>>>>
>>>> The drepl_replica_sync returns quickly but somehow it seems that either
>>>> the reply is not sent or it is lost, when I force the dc to be run in
>>>> single mode (so that all the tasks are in the same process) the error
>>>> message goes away.
>>> Per our IRC conversation today, attached is the patch I think we were
>>> both discussing.
>>>
>>> Please review, or consider this my review if your patch is essentially
>>> identical.
>> Yeah that's more or less the content of my patch (comments changed), so
>> I'll review it.
> In trying to chase down your autobuild failure with patch 4 here, I
> wrote up these additional patches to ensure our python code uses the
> correct types.
>
> The ldb fix in my other mail needs to be applied first.
>
> The combined set now passes autobuild.

So for patch 2 it's ok, for patch3 I'm not too confident with it I would 
love to have feedback from Metze or Jelmer, patch 4 is almost ok but I 
would merge the python part to patch 3 and have just patch 4 for the task.

Also I think the commit message is not correct because when we are in 
standard mode I don't think that the single_new_task is used that's 
where it was tricky: task were created with the prefork model but some 
of them were using the single_new_connection method for handling new 
connections.


Matthieu.

-- 
Matthieu Patou
Samba Team
http://samba.org