[PATCH] Fix bug #9572 - File corruption during SMB1 read by Mac OSX 10.8.2 clients.
Stefan (metze) Metzmacher
metze at samba.org
Thu Jan 24 01:34:41 MST 2013
Hi Jeremy,
> - if ((sconn->smb1.unix_info.client_cap_low & CIFS_UNIX_LARGE_READ_CAP) ||
> - (get_remote_arch() == RA_SAMBA)) {
> - /*
> - * This is Samba only behavior (up to Samba 3.6)!
> - *
> - * Windows 2008 R2 ignores the upper_size,
> - * so we do unless unix extentions are active
> - * or "smbclient" is talking to us.
> - */
Can you add the this comment to your patch, it would be bad to
loose this.
smbclient from 4.0 would not result in RA_SAMBA.
Otherwise the patches look good.
Reviewed-by: Stefan Metzmacher <metze at samba.org>
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130124/4d3e1641/attachment.pgp>
More information about the samba-technical
mailing list