ldb + samdb perfs and ideas for perf improvement

[Andrew Bartlett]

On Mon, 2013-01-21 at 20:37 -0800, Matthieu Patou wrote:
> On 01/20/2013 11:27 PM, Andrew Bartlett wrote:

> > Have you seen the comments metze has in his branch?
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-tmp3
> >
> > It is for metze to write these up formally for you, but I just wanted
> > you get get some sense that this is being looked at, and there is some
> > feedback you can expect soon.  Metze I know has been busy trying to sort
> > out the ACLs, with the patches we have both done recently now finally
> > being in shape to get into the tree.
> >
> > In terms of those reviews, I tend to agree with metze's terse markers so
> > far.
> Terse is the word, the thing is that some patches (like  ldb: Add more 
> data test data for one level test cases) shouldn't be pushed before the 
> new code for ldb_dn_compare_xxx as the current code in lib/ldb has a bug.
> 
> Also I'd like to understand what "later" means, if it means I'll review 
> later why not, but when ?
> 
> I'd like also to point out that ldb: Make ldb_match_scope and 
> ldb_match_message available to other module need to change the ABI files 
> and bump the version.
> Finally it seems that "dsdb-operational: rework the loop for attribute 
> removal"  hasn't received any comments.

Metze,

Can you give me a simple indication as to if you have the time and
energy to review Matthieu's patches, or if you are happy for someone
else (say me or Simo) to review them?  

I don't want to step on your toes, but likewise I haven't had the time
and energy to dig into this properly either, except the same cursory
glances on a the same obvious things you note in your branch there. 

We need to give Matthieu some hope here, and if I know what your
thoughts or plans are, it can help me figure out what I need to do to
move us forward here. 

Simo,

Are you also intending to do a formal review on this?  I've not seen
anything other than your initial comments, which I think where
addressed. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org