[PATCHS] fix waf test --testenv --screen, improve test speed

[Matthieu Patou]

Dear all,


On 01/16/2013 12:26 AM, Matthieu Patou wrote:
> On 01/08/2013 11:31 PM, Andrew Bartlett wrote:
>> On Tue, 2013-01-08 at 21:52 -0800, Matthieu Patou wrote:
>>> Hello,
>>>
>>> Can I have the review of the following 4 patches:
>>>
>>> * 0001-Tests-rewrite-ldap_schema-to-specify-attributes.patch, this more
>>> a demo of what we can gain when doing specifying attributes instead of
>>> doing a * search
>> This looks good.
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>>> * 0002-Tests-Fix-the-display-of-test-vars-in-screen-testenv.patch,
>>> environment variable for the test weren't displayed
>> This still needs work, because I only just added it in:
>> 60003e5604ab7c52eef9694bf0bec8facf4c0f1b
>>   selftest: use an array when starting testenv with system()
>>           By reduing the need for escapes and forcing the use of 
>> bash, this
>>      seems to allow 'make testenv' to start on FreeBSD
>>           Andrew Bartlett
>>           Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
>>      Autobuild-Date(master): Sun Sep 30 02:30:40 CEST 2012 on
>> sn-devel-104
>>
> I updated the patch, so that we don't use bash only in the screen case 
> as it's :
> 1) not working
> 2) bash is already called in in_screen
>
>
If I don't have a review I'll push it without review ... Jeremy I'm 
still waiting for your review.

Matthieu.

-- 
Matthieu Patou
Samba Team
http://samba.org