[PATCH] Fix up strerror_r again (correcting previous libreplace work)

Andrew Bartlett abartlet at samba.org
Fri Jan 18 14:25:26 MST 2013


On Fri, 2013-01-18 at 14:49 +0100, Bjoern Baumbach wrote:
> Hi Andrew,
> 
> On 01/12/2013 12:35 AM, Andrew Bartlett wrote:
> > The attached patch again tries to sort out the strerror_r situation.  We
> > now do not put it in libreplace on systems with any strerror_r, and we
> > let Heimdal provide rk_strerror_r as a XSI-style function when what is
> > provided is the GNU style function.
> > 
> > I would appreciate some review of this, because I managed to muck this
> > up quite badly last time, and somehow I still managed to get
> > c704f0daa5e81911ea2b507323b5005303f61e91 into the tree despite comments
> > that I should have paid closer attention to. 
> > 
> > In particular, while I've asked offline for the Solaris 8 user I have
> > been working with to test this, if someone else on a system without
> > strerror_r could double-check this work, it would be most valuable.
> 
> Your patch applied to samba_4_0_test and the result on sun8 was:
> 
> Waf: Leaving directory `/export/home/build/build_farm/samba_4_0_test/bin'
> 'build' finished successfully (1h53m45.097s)

Thank you very much. 

Metze,

Can you review and push it for me?

Thanks,

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list