DSDB-ACL work

[Stefan (metze) Metzmacher]

Am 18.01.2013 02:52, schrieb Andrew Bartlett:
> On Thu, 2013-01-17 at 16:32 +0100, Stefan (metze) Metzmacher wrote:
>> Hi Andrew,
>>
>> can you have a look at my progress the work to correct the dsdb acl
>> handling,
>> it's based on your patches, but reworked in some details to make then
>> easier to
>> understand.
>>
>> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master-ready
>>
>> I use acl_check_access_on_attribute() in a few more places and introduced
>> a acl_check_access_on_objectclass() function.
>>
>> I haven't done much testing with it yet, but I expect it to work as
>> desired now.
> 
> Thank you so much for working on that.  I've read over them, and it
> seems reasonable, but I need to do more of a review.
> 
> What is missing is a test for the read ACL stuff, that starts to work
> after the pre-windows 2000 compatible access patch goes in.

Yes, we need a lot more tests for this kind of stuff.
But this will take time..., I'm not sure if we should delay the release.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130118/8af14d90/attachment.pgp>