CTDB patches for hardening

[Amitay Isaacs]

Hi Matthieu,

On Wed, Jan 16, 2013 at 5:31 AM, Mathieu Parent <math.parent at gmail.com>wrote:

> 2013/1/15 Amitay Isaacs <amitay at gmail.com>:
> >
> > On Tue, Jan 15, 2013 at 10:10 AM, Amitay Isaacs <amitay at gmail.com>
> wrote:
> >>
> >>
> >> On Mon, Jan 14, 2013 at 8:20 PM, Mathieu Parent <math.parent at gmail.com>
> >> wrote:
> >>>
> >>> 2013/1/13 Amitay Isaacs <amitay at gmail.com>:
> >>> > Hi Matthieu,
> >>> [...]
> >>> [Patches list:]
> >>> >>   Add missing LDFLAGS
> >>> >>   Display compiler commands
> >>> [...]
> >>>
> >>> > Thanks for the patches.  The second patch is unnecessary as make will
> >>> > print
> >>> > CFLAGS and LIBS before compilation starts.
> >>>
> >>> Yes, appart from when some flags are missing ;-). Like what is solved
> >>> by the first patch.
> >>>
> >>> But I agree that the build is less pretty then (see
> >>>
> >>>
> https://buildd.debian.org/status/fetch.php?pkg=ctdb&arch=i386&ver=2.1-1&stamp=1358010554
> ).
> >>>
> >>> If you don't want to apply the second patch, LDFLAGS should also be
> >>> printed.
> >>
> >>
> >> Sold. :)
>
> Thanks.
>
> > Well, currently LDFLAGS are printed as part of LIBS output. Do you want
> to
> > see them separately?
>
> Not necessarily.
>
> Attached are all my patches with signed-off:
> 0001-Add-missing-LDFLAGS.patch
> 0002-Display-compiler-commands.patch
> 0003-allows-to-allows-one-to.patch
> 0004-Update-config.guess-2012-12-30-and-config.sub-to-201.patch
>


0002 is unnecessary since LDFLAGS are printed as part of LIBS output.
0004 should drop updates to lib/replace. I would prefer not to make any
changes to lib/replace directly. Make changes upstream (samba) and then
sync in ctdb tree.



> Some new platform patches:
> 0005-Detailed-platform-specific-FIXME.patch
> 0006-FreeBSD-kFreeBSD-Implement-get_process_name-same-as-.patch
> 0007-Test-portability.patch
> 0008-Don-t-lie-on-unimplemented-gratuitous-arp.patch
>
>
These patches look good. May be we can add a simple test that runs test
portability as part of the test suite.



> Regards
> --
> Mathieu
>

Amitay.