[PATCH] Fix FSMO timeoutes by clearing transaction buffer

[Andrew Bartlett]

I'm working to try and sort out the many and various issues with DRS in
Samba 4.0.0. 

The attached patches seem to help one part of it.  If we remove the
transaction while doing the IRPC call to take over an FSMO role, we no
longer time out here.

This fixes a number of our tests, that would have passed before we
swapped the 'dc' environment from 'single' to 'standard' process
modal.  

Interestingly, putting the system back into 'single' mode in make test
(modifying Samba4.pm) makes 'make test TESTS="drs fsmo"' pass. 

Otherwise, we get a new timeout in the ReplDisabledForced subtest in
replicay_sync.py.

I'm looking into what fails to talk to what, to cause this particular
error, but I figured I would mention these patches to the list, so
others know I'm working here.  The DRS tests seem very delicately poised
- fix one thing, or change something unrelated and they can fail.  We
need to make the DRS code much more reliable.

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Fix-talloc-issues-in-dsdb_schema_copy_shallow.patch
Type: text/x-patch
Size: 2817 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130115/9809c29e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-drs-fsmo-Improve-handling-of-FSMO-role-takeover.patch
Type: text/x-patch
Size: 2764 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130115/9809c29e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-selftest-also-skip-raw.search-as-it-also-spins.patch
Type: text/x-patch
Size: 847 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130115/9809c29e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dsdb-Do-not-hold-the-transaction-over-the-IRPC-call-.patch
Type: text/x-patch
Size: 3627 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130115/9809c29e/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-torture-Fix-fsmo-test-to-use-correct-H-samba-tool-sy.patch
Type: text/x-patch
Size: 1381 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130115/9809c29e/attachment-0004.bin>