[PATCHS] fix waf test --testenv --screen, improve test speed

[Andrew Bartlett]

On Tue, 2013-01-08 at 21:52 -0800, Matthieu Patou wrote:
> Hello,
> 
> Can I have the review of the following 4 patches:
> 
> * 0001-Tests-rewrite-ldap_schema-to-specify-attributes.patch, this more 
> a demo of what we can gain when doing specifying attributes instead of 
> doing a * search

This looks good.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

> * 0002-Tests-Fix-the-display-of-test-vars-in-screen-testenv.patch, 
> environment variable for the test weren't displayed

This still needs work, because I only just added it in:
60003e5604ab7c52eef9694bf0bec8facf4c0f1b
 selftest: use an array when starting testenv with system()
    
    By reduing the need for escapes and forcing the use of bash, this
    seems to allow 'make testenv' to start on FreeBSD
    
    Andrew Bartlett
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Sep 30 02:30:40 CEST 2012 on
sn-devel-104

> * 0003-Tests-avoid-adding-python-options-that-are-functions.patch, 
> screen complains when there is python dumped functions in a environment 
> var so let's not do it

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

> * 0004-Tests-remove-redondent-testsuites-in-provision.patch, remove some 
> provision that we actually use directly or indirectly in other tests.

I guess provision has become so slow that we have to do this, but it
seems unfortunate to remove unit tests of these things, even if we test
these at the integration level. 

If we are going to remove the test for --partitions-only, then we should
remove the option from samba-tool doman provision as well.  (Likewise
for --blank). 

For the re-provision test, it is unfortunate that we now have it relying
on a side-effect of an earlier test.  I would prefer they were combined,
so at least it wasn't side-effect based. 

Thanks for your care and attention to the time our make test takes.  The
long duration takes a toll on us all, and I very much value the effort
you have put into this.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org