[RFC] tdb_traverse_read_lite()

[Rusty Russell]

Jeremy Allison <jra at samba.org> writes:
> On Thu, Feb 28, 2013 at 02:11:18PM +1030, Rusty Russell wrote:
>> Amitay asked me to look at a lightweight traverse for tdb.  This is my
>> first attempt (against his ctdb tree, but it's pretty simple).
>> 
>> Normal traverse drops the chain lock when calling the callback, and thus
>> has to handle deleting the record while it's traversing, which it does
>> by grabbing a lock on the record itself, which is then tested in
>> delete...
>> 
>> For simple callback functions, that's overkill.  So I implemented that
>> to measure performance.
>> 
>> >From 1de5f5259caa4c34a5d66d1d09c986a5de98f6ef Mon Sep 17 00:00:00 2001
>> From: Rusty Russell <rusty at rustcorp.com.au>
>> Date: Thu, 28 Feb 2013 14:06:53 +1030
>> Subject: [PATCH] tdb_traverse_read_lite(): lightweight traverse for tdb.
>
> Ok, nice idea but you should be flogged soundly for calling
> it 'read_*LITE*' :-). It's read_light() you monster.

lite is exactly what I meant.  It correctly reflects the discomfort that
I feel with bastardization of a once-clean interface.

Cheers,
Rusty.