EXPERIMENTAL: tevent_kqueue support

Jeremy Allison jra at samba.org
Wed Feb 20 10:36:30 MST 2013


On Wed, Feb 20, 2013 at 06:32:47PM +0100, Stefan (metze) Metzmacher wrote:
> Am 20.02.2013 01:50, schrieb Jeremy Allison:
> > On Sun, Feb 17, 2013 at 05:07:30PM +0100, Stefan (metze) Metzmacher wrote:
> >> Hi Timur,
> >>
> >> I've started with a tevent_kqueue implementation
> >> (just looking at the man page).
> >>
> >> It compiles for me on linux with the 2nd HACK patch.
> >>
> >> Can you have a look and test it?
> >>
> >> @Jeremy: we may want to pick up some of the simplified logic into the
> >> epoll backend:
> >>          kqueue_update_fd_event() instead of
> >>          epoll_add_event/epoll_mod_event/epoll_del_event/epoll_change_event.
> > 
> > Don't think that will work. The difference between epoll/kqueue
> > is that kqueue doesn't seem to have the restriction on adding
> > 2 events with the same fd, which means we'd have to migrate
> > all the logic in my epoll patch into a epoll_update_fd_event
> > function, which might get rather messy :-).
> 
> We already had a epoll_change_event(), which I renamed to
> epoll_update_event()
> and used in all places instead of using epoll_{add,mod,del}_event directly.
> 
> I current epoll patchset is attached, please take a look, but don't push
> it to master yet.

Ok, I'll run under test and wait for you to confirm you're
happy.

Cheers & thanks,

	Jeremy.


More information about the samba-technical mailing list