[PATCH] upgradeprovision tests and patches for review

Andrew Bartlett abartlet at samba.org
Sat Feb 16 05:02:29 MST 2013

On Sat, 2013-02-16 at 14:30 +1100, Andrew Bartlett wrote:
> On Sat, 2013-02-16 at 01:35 +1100, Andrew Bartlett wrote:
> > On Fri, 2013-02-15 at 21:02 +1100, Andrew Bartlett wrote:
> > > On Fri, 2013-02-15 at 00:50 -0800, Matthieu Patou wrote:
> > 
> > > The tests I did to understand the behaviour here were against alpha13,
> > > but the version I'm most concerned about upgrading from is 4.0.0 (and
> > > versions prior to that with identical/similar templates).  If we expect
> > > that the behaviour of the two versions will be quite different, then
> > > I'll add another expanded tree to the repository. 
> > 
> > I've now don that, in my upgradeprovision branch
> My upgradeprovision branch at
> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/upgradeprovision includes a number of patches I've been seeking review on for the past little while, and the work I've been doing in the last few days.  
> We now have a 4.0.0 provision in the tree, and have tests to ensure that
> upgradeprovision works correctly on that.   This does take some time,
> but it is important we can validate it if we are going to recommend it
> to our users.
> The current issues with SD values being incorrect are marked with a
> knownfail for now, until that can be addressed, so that we at least test
> the rest of the process. 
> I would very much appreciate it if you could review and or push any
> parts of this that you are comfortable with.

I've found the fundamental cause of the major issues here.  There was
code that was looking for the string alpha9/10/... as an indication of a
modern Samba.  The attached patch, which is the top patch on the updated
tree above, changes the auto-detection to be a command line option.

With these patches, we no longer as badly corrupt a current provision.
We still need to avoid creating new objects under CN=Partitions
(duplicating the guid-based DNS partitions) in --full mode, and we need
to fix some more ACLs, but it's better than it was. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba_upgradeprovision-Remove-auto-detection-of-pre-.patch
Type: text/x-patch
Size: 4761 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130216/61cada87/attachment.bin>

More information about the samba-technical mailing list