[PATCH] Change tevent "standard" backend to fall back from epoll -> poll
jra at samba.org
Fri Feb 15 10:14:46 MST 2013
On Fri, Feb 15, 2013 at 04:59:46PM +0100, Stefan (metze) Metzmacher wrote:
> Am 14.02.2013 23:02, schrieb Jeremy Allison:
> > On Thu, Feb 14, 2013 at 04:04:34PM +0100, Stefan (metze) Metzmacher wrote:
> >> Hi Jeremy,
> >>> Second attempt :-). This is the original patchset
> >>> forward ported to master after Volker and Metze fixed
> >>> the issues with the poll backend.
> >>> Please review and push to master if you're happy with it !
> >> I reviewed it and made some changes to it to fix some details
> >> and make it easier to understand for me.
> >> - I added a replay flag to epoll_panic() to indicate if it was called
> >> from before calling an event handler or from within an event handler.
> >> We should only call loop_once() of the poll backend if epoll_panic
> >> was called before calling an event handler.
> >> tevent_loop_once() should only trigger just one event handler.
> >> - I introduced a 'struct std_event_glue' instead of using
> >> tricks with const struct tevent_ops **
> >> I've tested the fallback with the last two HACK patches,
> >> which are reverted again and should not reach master.
> > Pushed to master (without that HACK patches :-).
> The HACK patches actually discovered some problems with the fallback...
> I spend the day with debugging and fixing...
> I'll do some more testing with the attached patches next week.
Ok, I'll rebase the multiplex fixes on top of your
new changes to tevent_epoll.c to help make the review
More information about the samba-technical