[PATCH] Change tevent "standard" backend to fall back from epoll -> poll

Jeremy Allison jra at samba.org
Thu Feb 14 11:00:04 MST 2013

On Thu, Feb 14, 2013 at 04:04:34PM +0100, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> > Second attempt :-). This is the original patchset
> > forward ported to master after Volker and Metze fixed
> > the issues with the poll backend.
> > 
> > Please review and push to master if you're happy with it !
> I reviewed it and made some changes to it to fix some details
> and make it easier to understand for me.
> - I added a replay flag to epoll_panic() to indicate if it was called
>   from before calling an event handler or from within an event handler.
>   We should only call loop_once() of the poll backend if epoll_panic
>   was called before calling an event handler.
>   tevent_loop_once() should only trigger just one event handler.
> - I introduced a 'struct std_event_glue' instead of using
>   tricks with const struct tevent_ops **
> I've tested the fallback with the last two HACK patches,
> which are reverted again and should not reach master.
> I'm currently doing private autobuilds with and without the hack patches.

These fixes look good to me - thanks for the updates !


More information about the samba-technical mailing list