[PATCH] Revert "selftest: skip smb2.ioctl tests on ntvfs"

[Andrew Bartlett]

On Sun, 2013-02-03 at 17:15 +0100, David Disseldorp wrote:
> This reverts commit cf27c2fbb6e7422cb962f4c63a53515321c65a70.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

> The following concerns were raised with regard to the relocation of
> tests from selftest/knownfail to selftest/skip.
> 
> Andrew Bartlett <abartlet at samba.org> wrote:
> 
> Unless there is some entirely undesirable side-effect, this patch throws
> away valuable testing, because it removes the test of the testsuite for
> failure (ie, does the test work!), and it removes the documentation of
> the difference between the servers (if someone did add some this to the
> ntvfs server, it would never be tested).
> 
> It also removes a test that if this unimplemented functionality is
> called, that we don't crash and die.
> ---
>  selftest/knownfail |    2 ++
>  selftest/skip      |    1 -
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/selftest/knownfail b/selftest/knownfail
> index dcd94ec..39485af 100644
> --- a/selftest/knownfail
> +++ b/selftest/knownfail
> @@ -172,6 +172,8 @@
>  ^samba3.smb2.durable-v2-open.open-lease
>  ^samba3.smb2.durable-v2-open.persistent-open-lease
>  ^samba3.smb2.durable-v2-open.app-instance
> +^samba4.smb2.ioctl.req_resume_key\(dc\) # not supported by s4 ntvfs server
> +^samba4.smb2.ioctl.copy_chunk_\w*\(dc\)	# not supported by s4 ntvfs server
>  ^samba3.smb2.dir.one
>  ^samba3.smb2.dir.modify
>  ^samba3.smb2.lease.request
> diff --git a/selftest/skip b/selftest/skip
> index d54a5b0..5c49306 100644
> --- a/selftest/skip
> +++ b/selftest/skip
> @@ -61,7 +61,6 @@
>  ^samba4.smb2.dir
>  ^samba4.smb2.session
>  ^samba4.smb2.compound
> -^samba4.smb2.ioctl	# not supported by ntvfs
>  ^samba4.ntvfs.cifs.*.base.charset
>  ^samba4.ntvfs.cifs.*.base.iometer
>  ^samba4.ntvfs.cifs.*.base.casetable

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org