[PATCH 1/2] s3-auth: fix force user for AD user

Andrew Bartlett abartlet at samba.org
Tue Dec 17 13:52:20 MST 2013


On Tue, 2013-12-17 at 16:20 +0100, Andreas Schneider wrote:
> On Saturday 14 December 2013 07:37:52 Andrew Bartlett wrote:
> > > Günther and I are working on it. Here is our WIP branch:
> > > 
> > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/force_user
> > 
> > This looks like a much better approach!
> 
> Hi Andrew,
> 
> here is the proposed patchset:
> 
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/force_user
> 
> I will run 'make test' but this should work. Could you please take another 
> look?

The main issue I see is that this new (great!) codepath is called for
users from /etc/passwd, not just users from winbind forced in via force
user.  See the callers in auth_unix.c and user_krb5.c.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list