[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

On Mon, Dec 16, 2013 at 10:34:46AM -0800, Jeremy Allison wrote:
> On Sat, Dec 14, 2013 at 01:20:04PM +0100, Stefan Metzmacher wrote:
> > 
> > commit 5baa7402ba8eebd9b2ddc6b259ae9bb2852b4bb1
> > Author: Volker Lendecke <vl at samba.org>
> > Date:   Fri Dec 6 14:34:05 2013 +0000
> > 
> >     smbd: Implement and use full_path_tos
> >     
> >     Yes, this looks like a hack, but talloc_asprintf does show up high in
> >     profiles called from these routines
> >     
> >     Signed-off-by: Volker Lendecke <vl at samba.org>
> >     Reviewed-by: Stefan Metzmacher <metze at samba.org>
> 
> Hahaha ! Coming this summer to a cinema near you :
> 
> "Samba 4 - Revenge of the pstrings" :-) :-).

Sorry for that :-)

> 
> Great work though. I take it this was a cachegrind
> find ?

Yes, and the sum of all those changes is significantly
measurable using netbench even on a reasonably powerful
server maching, not only on the Raspberry Pi. It was not the
talloc mainly here, it was the double run of snprintf that
bit here I think. So talloc with explicit strlen + memcpy
would have gained us quite a bit as well. But while there I
thought why not remove the talloc also.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de