[PATCH] Require explicit 'without flags' for acl, ldap and ads

[Garming Sam]

On 17/12/13 01:54, Jelmer Vernooij wrote:
> On Mon, Dec 16, 2013 at 04:45:19PM +1300, Andrew Bartlett wrote:
>> On Mon, 2013-12-16 at 16:25 +1300, Garming Sam wrote:
>>> These patches are designed to make it more difficult to build Samba
>>> without ACL, LDAP or ADS support. By default, it is already set to
>>> include support for these and by requiring them to included, it makes it
>>> easier to ensure that the build is fully functional (or in any case,
>>> indicates the packages which should be expected by default).
>>>
>>> We would subsequently have to work with the build farm to update it to
>>> have these additional options set. Otherwise, we could attempt to get
>>> the owners to install the missing packages.
>> Thanks Garming!
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> Can I get some comment and review from others on the team?  Remember,
>> nothing about this prevents a build working that worked before, but it
>> might just require an explicit --without flag or two.  This is based on
>> what I wrote in BUILD_SYSTEMS.txt back before 4.0, but never had time to
>> implement.
>>
>> This is related to the recent enquiry from Gentoo.
> LGTM. The only reservation I have is about showing this error to users who
> can't install the acl or xattr libraries because they're not available for
> their platforms.
>
> Do we consider platforms that don't have these libraries second-class citizens?
> Can we suggest users migrate to a platform that does have those libraries?
>
> Cheers,
>
> Jelmer

Modified the messages to be slightly more informative and why the 
support should be included.


I think it would be a good idea to consider platforms that don't have 
these libraries to be second class.

As for suggesting migration, I think it's a little unreasonable and 
likely the best thing to do is just to give them a slight nudge by 
saying which features they're actually missing out on.


Cheers,

Garming Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-waf-Require-ACL-support-to-be-specifically-disabled.patch
Type: text/x-patch
Size: 1828 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131217/1089349b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-waf-Require-ldap-support-to-be-specifically-disabled.patch
Type: text/x-patch
Size: 1080 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131217/1089349b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-waf-Require-without-ads-support-to-build-without-ADS.patch
Type: text/x-patch
Size: 1669 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131217/1089349b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-waf-fix-a-typo-in-an-ADS-error-message.patch
Type: text/x-patch
Size: 1164 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131217/1089349b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-doc-Modify-build-doc-concerning-missing-headers.patch
Type: text/x-patch
Size: 1999 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131217/1089349b/attachment-0004.bin>