[SCM] Samba Shared Repository - branch master updated

Simo simo at samba.org
Mon Dec 16 14:26:58 MST 2013


On Mon, 2013-12-16 at 13:05 -0800, Jeremy Allison wrote:
> On Mon, Dec 16, 2013 at 03:56:16PM -0500, Simo wrote:
> > On Mon, 2013-12-16 at 10:34 -0800, Jeremy Allison wrote:
> > > On Sat, Dec 14, 2013 at 01:20:04PM +0100, Stefan Metzmacher wrote:
> > > > 
> > > > commit 5baa7402ba8eebd9b2ddc6b259ae9bb2852b4bb1
> > > > Author: Volker Lendecke <vl at samba.org>
> > > > Date:   Fri Dec 6 14:34:05 2013 +0000
> > > > 
> > > >     smbd: Implement and use full_path_tos
> > > >     
> > > >     Yes, this looks like a hack, but talloc_asprintf does show up high in
> > > >     profiles called from these routines
> > > >     
> > > >     Signed-off-by: Volker Lendecke <vl at samba.org>
> > > >     Reviewed-by: Stefan Metzmacher <metze at samba.org>
> > > 
> > > Hahaha ! Coming this summer to a cinema near you :
> > > 
> > > "Samba 4 - Revenge of the pstrings" :-) :-).
> > 
> > Uhm, given this string is never passed anywhere and you want to use the
> > stack, why didn't you simply use alloca() + snprintf() ?
> > 
> > That would seem a lot simpler and as effective to me, am I missing
> > something ?
> 
> I don't think alloca is as portable as the code
> Volker wrote.

I see.

Simo.



More information about the samba-technical mailing list