[PATCH] Require explicit 'without flags' for acl, ldap and ads

Jelmer Vernooij jelmer at samba.org
Mon Dec 16 05:54:57 MST 2013

On Mon, Dec 16, 2013 at 04:45:19PM +1300, Andrew Bartlett wrote:
> On Mon, 2013-12-16 at 16:25 +1300, Garming Sam wrote:
> > These patches are designed to make it more difficult to build Samba 
> > without ACL, LDAP or ADS support. By default, it is already set to 
> > include support for these and by requiring them to included, it makes it 
> > easier to ensure that the build is fully functional (or in any case, 
> > indicates the packages which should be expected by default).
> > 
> > We would subsequently have to work with the build farm to update it to 
> > have these additional options set. Otherwise, we could attempt to get 
> > the owners to install the missing packages.
> Thanks Garming!
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> Can I get some comment and review from others on the team?  Remember,
> nothing about this prevents a build working that worked before, but it
> might just require an explicit --without flag or two.  This is based on
> what I wrote in BUILD_SYSTEMS.txt back before 4.0, but never had time to
> implement.  
> This is related to the recent enquiry from Gentoo. 

LGTM. The only reservation I have is about showing this error to users who
can't install the acl or xattr libraries because they're not available for
their platforms.

Do we consider platforms that don't have these libraries second-class citizens?
Can we suggest users migrate to a platform that does have those libraries?



More information about the samba-technical mailing list