[PATCHES] smbcontrol disconnect-client
cs at samba.org
Thu Dec 12 10:55:41 MST 2013
On Wed, Dec 11, 2013 at 04:29:03PM -0800, Jeremy Allison wrote:
> On Wed, Dec 11, 2013 at 11:15:10AM -0700, Christof Schmitt wrote:
> > Changing the name is easy. :-)
> > I took a look at the suggestions and it should not be too difficult to
> > implement a call that revokes all oplocks. So we could have two calls to
> > disconnect a client:
> > 1) smbcontrol kill-client-connections:
> > - Just exit the server.
> > 2) smbcontrol drop-client-connections:
> > - Set a flag to no longer grant exclusive oplocks
> > - Send a break for all exclusive oplocks
> > - When oplocks.exclusive_open is zero, then exit.
> > This should always work, since oplocks are considered broken after
> > the OPLOCK_BREAK_TIMEOUT.
> > What is the best way forward here? Rename the control to
> > kill-client-connections and push the patches? And then start working on
> > the second command?
> How about 'kill-client-ip' - more specific ?
> Here is the modified patchset that implements
> the rename. Let me know if you're ok with it
> (and feel free to push if happy).
Looks good. I fixed the signed-off-by on the doc patch and pushed the
patches to autobuild.
More information about the samba-technical