[PATCH v2 0/0] Remove duplicate DCE/RPC PDU unmarshalling

Stefan (metze) Metzmacher metze at samba.org
Wed Dec 11 09:22:17 MST 2013

Am 11.12.2013 14:16, schrieb David Disseldorp:
> Hi Jeremy,
> Jeremy Allison <jra at samba.org> wrote:
>> David - *however* did you spot this ?
> I came across it while looking into an ndr bug that Metze fixed.

The changes from Andreas to always use tstream_npa_socketpair()
for the smbd internal named pipe changed the code to use
in all code paths, so we were finally able to remove the 2nd unmarshall

When we have Gregor's and my patches to use tstream in the
source4/librpc/rpc code
pushed, we're able to think about replacing our 4 dcerpc implementation
with just one.

>> This is a really great patch !
>> I'm still waiting to see it go through
>> autobuild (deleted it by mistake from
>> my inbox), but I really don't want to
>> see this lost :-).
> Thanks! I'm about to board a plane, and haven't had
> time to look at why it didn't make it through autobuild.
> Will do a few more selftest runs during the flight.

I think it was just flakey, I had 2 private autobuilds without problems.

It will be in master if it passes 2 addtional ones.


More information about the samba-technical mailing list