[PATCH v2] s3/rpc_server: don't unmarshall PDUs twice

Stefan (metze) Metzmacher metze at samba.org
Tue Dec 10 10:10:59 MST 2013

Hi David,

> DCE/RPC PDUs are currently unmarshalled firstly by the generic librpc
> dcerpc_read_ncacn_packet_[send/recv] functions, and subsequently a
> second time by the source3 rpc_server, which ignores the unmarshalled
> packet and re-parses the receive buffer.
> With the removal of this re-parse logic, a large amount of duplicate
> unmarshalling code can also be removed.

Thanks! Pushed to autobuild.


More information about the samba-technical mailing list