[PATCH 0/2] Remove duplicate DCE/RPC PDU unmarshalling

David Disseldorp ddiss at samba.org
Tue Dec 10 07:34:25 MST 2013


The source3 DCE/RPC server uses the generic librpc library to retrieve
PDUs but ignores the returned unmarshalled packet, and instead re-parses
the raw packet buffer.

Feedback appreciated.

Cheers, David

The following changes since commit f98d10af2a05f0261611f4cabdfe274cd9fe91c0:

  smbd: Always use UCF_PREP_CREATEFILE for filename_convert calls to resolve a path for open. (2013-12-09 21:02:21 +0100)

are available in the git repository at:

  git://git.samba.org/ddiss/samba dcerpc

for you to fetch changes up to 0b895ec36348c98810e13b4d74b45d8d2145441a:

  s3/rpc_server: remove unused PDU [un]marshalling code (2013-12-10 15:05:39 +0100)

----------------------------------------------------------------
David Disseldorp (2):
      s3/rpc_server: don't unmarshall PDUs twice
      s3/rpc_server: remove unused PDU [un]marshalling code

 source3/rpc_server/rpc_server.c   |  59 +++++++++-------------
 source3/rpc_server/rpc_server.h   |   2 +-
 source3/rpc_server/srv_pipe.c     |  52 ++------------------
 source3/rpc_server/srv_pipe_hnd.c | 366 -----------------------------------------------------------------------------------------------------------------------------------------
 source3/rpc_server/srv_pipe_hnd.h |   2 -
 5 files changed, 28 insertions(+), 453 deletions(-)




More information about the samba-technical mailing list