[PATCH 4/5 linux-next V2] cifs: fix incorrect reference count check

Tim Gardner timg at tpi.com
Sun Dec 8 14:08:43 MST 2013

The reference count on tlink can only be decremented if
cifs_sb_tlink(cifs_sb) was used to acquire it. That only
happens if open_file==NULL.

Cc: Steve French <sfrench at samba.org>
Cc: Jeff Layton <jlayton at redhat.com>
Cc: Dean Gehnert <deang at tpi.com>
Signed-off-by: Tim Gardner <timg at tpi.com>

V2 - this is a new patch in the V2 series.

 fs/cifs/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 3f710c6..e332038 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -2007,7 +2007,7 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs,
 			CIFSSMBClose(xid, tcon, netfid);
-	if (tlink)
+	if (!open_file)

More information about the samba-technical mailing list