[PATCH] Fix bug 10305 - bad if test in ldb.

Andrew Bartlett abartlet at samba.org
Sat Dec 7 12:06:53 MST 2013

On Sat, 2013-12-07 at 09:18 +0100, Michael Adam wrote:
> On 2013-12-06 at 16:05 -0800, Jeremy Allison wrote:
> > Can I get a second review for this one ?
> Pushed to autobuild.

I've been trying to decide how serious this would have been for callers.

I think the only possible outcome is a crash, and only if there was no
NULL terminator to the string (valid, but often we have a NULL
terminator despite not needing it).

I was worried we might have been able to give an incorrect match, which
would have much more serious implications. 

Do you agree?

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list