shall libreplace become a public library (Was: Re: [SCM] Samba Shared Repository - branch master updated)

[Rusty Russell]

Christian Ambach <ambi at samba.org> writes:
> Am 29.11.13 23:16, schrieb Jelmer Vernooij:
>
>>> Subject: [PATCH 01/10] s3:utils remove orphaned code
>> Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
>
>>> Subject: [PATCH 02/10] lib/replace remove orphaned code
>> Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> Thanks you for the reviews. I have pushed those two and attached a set 
> of revised patches that still need reviews. So please have another look.
>
>> It might be intentional that the testsuite only uses the external
>> API, and that could be a reason why these are not including private.h
>> at the moment. Perhaps Rusty can comment on that.
>>
>>>  From 832a335f79bb20b15eb263e516d341846b5348b7 Mon Sep 17 00:00:00 2001
>>> From: Christian Ambach <ambi at samba.org>
>>> Date: Fri, 22 Nov 2013 05:19:16 +0100
>>> Subject: [PATCH 10/10] lib/ntdb optimize includes in ntdb tools
>>>
>>> use the private header (which will use libreplace or system headers) instead of direct includes of system includes
>>
>> Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
>>
>> ... but it'd be great if Rusty could have a look too.
>
> I have included all ntdb related patches again for a review by Rusty.

Thanks Christian.

These all look like really nice cleanups.

Thanks!
Rusty.