shall libreplace become a public library (Was: Re: [SCM] Samba Shared Repository - branch master updated)

[Jelmer Vernooij]

On Thu, Dec 05, 2013 at 10:45:01AM +0100, Christian Ambach wrote:
> Am 29.11.13 23:16, schrieb Jelmer Vernooij:
> 
> >>Subject: [PATCH 01/10] s3:utils remove orphaned code
> >Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> 
> >>Subject: [PATCH 02/10] lib/replace remove orphaned code
> >Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> Thanks you for the reviews. I have pushed those two and attached a
> set of revised patches that still need reviews. So please have
> another look.
> 
> >It might be intentional that the testsuite only uses the external
> >API, and that could be a reason why these are not including private.h
> >at the moment. Perhaps Rusty can comment on that.
> >
> >> From 832a335f79bb20b15eb263e516d341846b5348b7 Mon Sep 17 00:00:00 2001
> >>From: Christian Ambach <ambi at samba.org>
> >>Date: Fri, 22 Nov 2013 05:19:16 +0100
> >>Subject: [PATCH 10/10] lib/ntdb optimize includes in ntdb tools
> >>
> >>use the private header (which will use libreplace or system headers) instead of direct includes of system includes
> >
> >Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> >
> >... but it'd be great if Rusty could have a look too.
> 
> I have included all ntdb related patches again for a review by Rusty.
> 
> Cheers,
> Christian
> 

> From f28c643e9723e4febd37016b93d76932ac4fad26 Mon Sep 17 00:00:00 2001
> From: Christian Ambach <ambi at samba.org>
> Date: Fri, 22 Nov 2013 05:12:05 +0100
> Subject: [PATCH 1/8] s3:lib/asys modify included headers
> 
> use the headers from libreplace, not the system ones
> 
> Signed-off-by: Christian Ambach <ambi at samba.org>
> ---
>  source3/lib/asys/asys.h        | 6 ++----
>  source3/lib/asys/wscript_build | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/source3/lib/asys/asys.h b/source3/lib/asys/asys.h
> index 73f1051..468ac3f 100644
> --- a/source3/lib/asys/asys.h
> +++ b/source3/lib/asys/asys.h
> @@ -19,10 +19,8 @@
>  #ifndef __ASYS_H__
>  #define __ASYS_H__
>  
> -#include <sys/types.h>
> -#include <sys/stat.h>
> -#include <fcntl.h>
> -#include <unistd.h>
> +#include "../lib/replace/replace.h"
> +#include "../lib/replace/system/filesys.h"

Please use "system/replace.h" rather than relative paths.

>  /**
>   * @defgroup asys The async syscall library
> diff --git a/source3/lib/asys/wscript_build b/source3/lib/asys/wscript_build
> index 15de977..dca56c7 100644
> --- a/source3/lib/asys/wscript_build
> +++ b/source3/lib/asys/wscript_build
> @@ -2,7 +2,7 @@
>  
>  bld.SAMBA3_SUBSYSTEM('LIBASYS',
>  		     source='asys.c',
> -		     deps='PTHREADPOOL')
> +		     deps='PTHREADPOOL replace')

Is this necessary? waf should already be adding dependencies on
libreplace implicitly IIRC.

> From a0406d7e6a0c2d2aea3c51ff0d470a4015694e98 Mon Sep 17 00:00:00 2001
> From: Christian Ambach <ambi at samba.org>
> Date: Fri, 22 Nov 2013 05:13:56 +0100
> Subject: [PATCH 2/8] s3:pam_smbpass change includes
> 
> use the ones from libreplace instead of system ones
> 
> Signed-off-by: Christian Ambach <ambi at samba.org>

Reviewed-By: Jelmer Vernooij <jelmer at samba.org>

> From cbe8e372e6de9a1cd9830c37f680e6c60c1cb3f2 Mon Sep 17 00:00:00 2001
> From: Christian Ambach <ambi at samba.org>
> Date: Fri, 22 Nov 2013 05:13:17 +0100
> Subject: [PATCH 3/8] s3:vfs_btrfs change includes
> 
> use the ones from libreplace instead of system ones
> 
> Signed-off-by: Christian Ambach <ambi at samba.org>

Reviewed-By: Jelmer Vernooij <jelmer at samba.org>

> From 7d1e4361485f85d3e3c83e6d1340a30422862a02 Mon Sep 17 00:00:00 2001
> From: Christian Ambach <ambi at samba.org>
> Date: Fri, 22 Nov 2013 05:15:13 +0100
> Subject: [PATCH 4/8] lib/socket_wrapper fix compilation when libreplace is not
>  around
> 
> Signed-off-by: Christian Ambach <ambi at samba.org>

Reviewed-By: Jelmer Vernooij <jelmer at samba.org>

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131206/ac4d3459/attachment.pgp>