[PATCH] Re: netlogon_creds_cli_validate() in master4-schannel

[Stefan (metze) Metzmacher]

Hi Garming,

> + sudo bin/net rpc join -S 192.168.122.249 -Uroot%password12#
> No realm has been specified! Do you really want to join an Active
> Directory server?
> netlogon_creds_cli_ServerPasswordSet failed:
> NT_STATUS_INVALID_PARAMETER_MIX
> No realm has been specified! Do you really want to join an Active
> Directory server?
> netlogon_creds_cli_check failed with NT_STATUS_NOT_IMPLEMENTED
> libnet_join_ok: failed to open schannel session on netlogon pipe to
> server 192.168.122.249 for domain S3. Error was NT_STATUS_NOT_IMPLEMENTED
> Failed to join domain: failed to verify domain membership after joining:
> Not implemented

I've fixed the NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE and
NT_STATUS_NOT_IMPLEMENTED
code pathes in netlogon_creds_cli_check_caps(). I also added some comments.

I also check result in netlogon_creds_cli_auth_srvauth_done() before the
downgrade check.

I've updated my
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-schannel-ok
branch.

Can you reset with the new code. It would be good to know if
netlogon_creds_cli_ServerPasswordSet
still reports NT_STATUS_INVALID_PARAMETER_MIX.

metze